code review 6298063: cmd/api: handle empty API file, ignore -next in release

cmd/api: handle empty API file, ignore -next in release

[rsc, 2012-06-08 17:25:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-06-08 17:36:32]

LGTM

On Fri, Jun 8, 2012 at 10:25 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/api: handle empty API file, ignore -next in release
>
> Please review this at
http://codereview.appspot.com/**6298063/<http://codereview.appspot.com/6298063/>
>
> Affected files:
>  M src/cmd/api/goapi.go
>
>
> Index: src/cmd/api/goapi.go
> ==============================**==============================**=======
> --- a/src/cmd/api/goapi.go
> +++ b/src/cmd/api/goapi.go
> @@ -28,6 +28,7 @@
>        "os/exec"
>        "path"
>        "path/filepath"
> +       "runtime"
>        "sort"
>        "strconv"
>        "strings"
> @@ -98,6 +99,13 @@
>
>  func main() {
>        flag.Parse()
> +
> +       if !strings.Contains(runtime.**Version(), "weekly") {
> +               if *nextFile != "" {
> +                       fmt.Printf("Go version is %q, ignoring -next
> %s\n", runtime.Version(), *nextFile)
> +                       *nextFile = ""
> +               }
> +       }
>
>        if *forceCtx != "" {
>                setContexts()
> @@ -235,7 +243,11 @@
>        if err != nil {
>                log.Fatalf("Error reading file %s: %v", filename, err)
>        }
> -       return strings.Split(strings.**TrimSpace(string(bs)), "\n")
> +       text := strings.TrimSpace(string(bs))
> +       if text == "" {
> +               return nil
> +       }
> +       return strings.Split(text, "\n")
>  }
>
>  // pkgSymbol represents a symbol in a package
>
>
>

[rsc, 2012-06-08 17:45:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=8e7ad2db0833 ***

cmd/api: handle empty API file, ignore -next in release

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6298063