Issue 6297083: code review 6297083: os: make POSIX StartProcess work with chroot again.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6297083: code review 6297083: os: make POSIX StartProcess work with chroot again. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by hanwen-google

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

os: make POSIX StartProcess work with chroot again. Skip directory check in startProcess in the presence of SysProcAttr. Fixes issue 3649.

Patch Set 1 #

Patch Set 2 : diff -r 64b63f65303a https://code.google.com/p/go #

Patch Set 3 : diff -r 64b63f65303a https://code.google.com/p/go #

Patch Set 4 : diff -r 64b63f65303a https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/pkg/os/exec_posix.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hanwen-google

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2012-06-13 23:17:59 UTC) #1

hanwen-google

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 10 months ago (2012-06-15 04:17:49 UTC) #2

rsc

sent out http://codereview.appspot.com/6327054. once that is in i will submit this. russ

11 years, 10 months ago (2012-06-24 22:47:06 UTC) #4

rsc

11 years, 10 months ago (2012-06-24 23:33:58 UTC) #5

*** Submitted as 2aaa88600d48 ***

os: make POSIX StartProcess work with chroot again.

Skip directory check in startProcess in the presence of
SysProcAttr.

Fixes issue 3649.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6297083

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages