Issue 6296045: code review 6296045: exp/html/atom: add more atoms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6296045: code review 6296045: exp/html/atom: add more atoms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by nigeltao

Modified:
12 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

exp/html/atom: add more atoms. This completely covers the tags used by exp/html's parser. Before: 295 atoms; 1406 string bytes + 2048 tables = 3454 total data BenchmarkLookup 50000 59841 ns/op After: 322 atoms; 1508 string bytes + 2048 tables = 3556 total data BenchmarkLookup 50000 60159 ns/op

Patch Set 1 #

Patch Set 2 : diff -r 9b455eb64690 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9b455eb64690 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ff2e12aef85e https://code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+740 lines, -609 lines)			Patch
M	src/pkg/exp/html/atom/atom.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/html/atom/atom_test.go	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/pkg/exp/html/atom/gen.go	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/pkg/exp/html/atom/table.go	View	1	1 chunk	+662 lines, -606 lines	0 comments	Download
M	src/pkg/exp/html/atom/table_test.go	View	1	11 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 10 months ago (2012-06-06 09:01:08 UTC) #1

nigeltao

12 years, 10 months ago (2012-06-06 23:36:09 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=00f8c6b8bd88 ***

exp/html/atom: add more atoms.

This completely covers the tags used by exp/html's parser.

Before:
295 atoms; 1406 string bytes + 2048 tables = 3454 total data
BenchmarkLookup    50000         59841 ns/op

After:
322 atoms; 1508 string bytes + 2048 tables = 3556 total data
BenchmarkLookup    50000         60159 ns/op

R=r
CC=golang-dev
http://codereview.appspot.com/6296045

Expand All Messages | Collapse All Messages