code review 6278048: test/bench/go1: reduce fasta data size for linux/arm

test/bench/go1: reduce fasta data size for linux/arm

As discussed on golang-dev, reduce the size of the fasta
dataset to make it possible to run the go1 benchmarks on
small ARM systems.

Also, remove the 25m suffix from fasta data and Revcomp.

linux/arm: pandaboard OMAP4

BenchmarkBinaryTree17          1        70892426000 ns/op
BenchmarkFannkuch11            1        35712066000 ns/op
BenchmarkGobDecode            10         137146000 ns/op           5.60 MB/s
BenchmarkGobEncode            50          64953000 ns/op          11.82 MB/s
BenchmarkGzip          1        5675690000 ns/op           3.42 MB/s
BenchmarkGunzip        1        1207001000 ns/op          16.08 MB/s
BenchmarkJSONEncode            5         860424800 ns/op           2.26 MB/s
BenchmarkJSONDecode            1        3321839000 ns/op           0.58 MB/s
BenchmarkMandelbrot200        50          45893560 ns/op
BenchmarkRevcomp              10         135220300 ns/op          18.80 MB/s
BenchmarkTemplate              1        6385681000 ns/op           0.30 MB/s

[dave_cheney.net, 2012-06-04 04:51:22]

Hello rsc@golang.org, minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-06-04 04:53:24]

http://codereview.appspot.com/6278048/diff/5001/test/bench/go1/fasta_test.go
File test/bench/go1/fasta_test.go (right):

http://codereview.appspot.com/6278048/diff/5001/test/bench/go1/fasta_test.go#...
test/bench/go1/fasta_test.go:16: // TODO(dfc) remove this limitation after
precice gc.
"precise"

[dave_cheney.net, 2012-06-04 05:05:43]

PTAL.

Also, link to the discussion about the size of the fasta data.

https://groups.google.com/d/msg/golang-dev/Na9XE6mcQyY/RRpbNBgV1v8J

http://codereview.appspot.com/6278048/diff/5001/test/bench/go1/fasta_test.go
File test/bench/go1/fasta_test.go (right):

http://codereview.appspot.com/6278048/diff/5001/test/bench/go1/fasta_test.go#...
test/bench/go1/fasta_test.go:16: // TODO(dfc) remove this limitation after
precice gc.
On 2012/06/04 04:53:24, dsymonds wrote:
> "precise"

Done.

[dave_cheney.net, 2012-06-04 05:05:59]

Hello rsc@golang.org, minux.ma@gmail.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-06-04 06:43:57]

after this change, the name BenchmarkRevcomp25M is no longer accurate,
should we also drop the 25M suffix?

please update the results in description once CL 6282046 is in, thanks.

[dave_cheney.net, 2012-06-04 06:45:12]

> after this change, the name BenchmarkRevcomp25M is no longer accurate,
> should we also drop the 25M suffix?

I have no preference for the name, I'll let someone else decide.

[rsc, 2012-06-04 14:20:48]

LGTM

Please do remove 25M from the name.
Thanks.

[dave_cheney.net, 2012-06-04 23:54:31]

Hello rsc@golang.org, minux.ma@gmail.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-06-05 20:24:24]

LGTM

[dave_cheney.net, 2012-06-05 21:50:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=f5904003a449 ***

test/bench/go1: reduce fasta data size for linux/arm

As discussed on golang-dev, reduce the size of the fasta
dataset to make it possible to run the go1 benchmarks on
small ARM systems.

Also, remove the 25m suffix from fasta data and Revcomp.

linux/arm: pandaboard OMAP4

BenchmarkBinaryTree17          1        70892426000 ns/op
BenchmarkFannkuch11            1        35712066000 ns/op
BenchmarkGobDecode            10         137146000 ns/op           5.60 MB/s
BenchmarkGobEncode            50          64953000 ns/op          11.82 MB/s
BenchmarkGzip          1        5675690000 ns/op           3.42 MB/s
BenchmarkGunzip        1        1207001000 ns/op          16.08 MB/s
BenchmarkJSONEncode            5         860424800 ns/op           2.26 MB/s
BenchmarkJSONDecode            1        3321839000 ns/op           0.58 MB/s
BenchmarkMandelbrot200        50          45893560 ns/op
BenchmarkRevcomp              10         135220300 ns/op          18.80 MB/s
BenchmarkTemplate              1        6385681000 ns/op           0.30 MB/s

R=rsc, minux.ma, dsymonds
CC=golang-dev
http://codereview.appspot.com/6278048