Issue 6272048: code review 6272048: build: restore PATH before "dist banner"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6272048: code review 6272048: build: restore PATH before "dist banner" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by minux1

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

build: restore PATH before "dist banner" Fixes issue 3699.

Patch Set 2 : diff -r 685b1b62a34f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4fdf6aa4f602 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 4fdf6aa4f602 https://code.google.com/p/go/ #

Patch Set 5 : diff -r aa46d9ec8715 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/all.bash	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/all.bat	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2012-06-05 18:22:53 UTC) #1

http://codereview.appspot.com/6272048/diff/5001/src/all.bash File src/all.bash (right): http://codereview.appspot.com/6272048/diff/5001/src/all.bash#newcode11 src/all.bash:11: OLDPATH=$PATH OLDPATH="$PATH" same below no idea what to do ...

11 years, 10 months ago (2012-06-05 18:25:07 UTC) #2

minux1

PTAL. On 2012/06/05 18:25:07, r wrote: > http://codereview.appspot.com/6272048/diff/5001/src/all.bash#newcode11 > src/all.bash:11: OLDPATH=$PATH > OLDPATH="$PATH" > same ...

11 years, 10 months ago (2012-06-05 18:33:38 UTC) #3

minux1

11 years, 10 months ago (2012-06-06 12:19:27 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=2787cca7ac8f ***

build: restore PATH before "dist banner"
        Fixes issue 3699.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/6272048

Expand All Messages | Collapse All Messages