Issue 6261056: code review 6261056: cgo: enable cgo on netbsd/386 and netbsd/amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6261056: code review 6261056: cgo: enable cgo on netbsd/386 and netbsd/amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by jsing

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cgo: enable cgo on netbsd/386 and netbsd/amd64

Patch Set 1 : diff -r d34e1877830c https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r a98657dda373 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -11 lines)			Patch
M	doc/progs/run	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	misc/cgo/stdio/stdio_netbsd.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/go/build/build.go	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/net/cgo_netbsd.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/net/cgo_unix.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/user/lookup_unix.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/gcc_netbsd_386.c	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_netbsd_amd64.c	View		3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-05-31 16:40:21 UTC) #1

jsing

12 years, 9 months ago (2012-06-04 15:43:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=234f81072bb7 ***

cgo: enable cgo on netbsd/386 and netbsd/amd64

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6261056

Expand All Messages | Collapse All Messages