Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6257059: code review 6257059: path/filepath: implement documented SkipDir behavior

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by jan_mercl
Modified:
12 years, 9 months ago
Reviewers:
r, rsc
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

path/filepath: implement documented SkipDir behavior Currently walk() doesn't check for err == SkipDir when iterating a directory list, but such promise is made in the docs for WalkFunc. Fixes issue 3486.

Patch Set 1 #

Patch Set 2 : diff -r 40632db23c46 https://code.google.com/p/go #

Patch Set 3 : diff -r 40632db23c46 https://code.google.com/p/go #

Patch Set 4 : diff -r 40632db23c46 https://code.google.com/p/go #

Patch Set 5 : diff -r 40632db23c46 https://code.google.com/p/go #

Total comments: 2

Patch Set 6 : diff -r dcf29da2044b https://code.google.com/p/go #

Total comments: 2

Patch Set 7 : diff -r d34e1877830c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M src/pkg/path/filepath/path.go View 1 2 3 4 5 6 1 chunk +5 lines, -2 lines 0 comments Download
M src/pkg/path/filepath/path_test.go View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 17
jan_mercl
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 9 months ago (2012-05-26 11:25:20 UTC) #1
r
the issue documents a test case. it would be nice to add that validation to ...
12 years, 9 months ago (2012-05-26 17:24:02 UTC) #2
jan_mercl
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-05-27 19:44:02 UTC) #3
jan_mercl
2012/5/26 <r@golang.org>: > the issue documents a test case. it would be nice to add ...
12 years, 9 months ago (2012-05-27 19:44:21 UTC) #4
jan_mercl
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-05-27 19:59:52 UTC) #5
jan_mercl
2012/5/27 Honza <befelemepeseveze@gmail.com>: > Done. I'm guess it's much more lines than you are going ...
12 years, 9 months ago (2012-05-27 20:00:22 UTC) #6
r
http://codereview.appspot.com/6257059/diff/1003/src/pkg/path/filepath/path_test.go File src/pkg/path/filepath/path_test.go (right): http://codereview.appspot.com/6257059/diff/1003/src/pkg/path/filepath/path_test.go#newcode879 src/pkg/path/filepath/path_test.go:879: var tempDir string i can't believe it's this hard ...
12 years, 9 months ago (2012-05-29 16:49:22 UTC) #7
jan_mercl
http://codereview.appspot.com/6257059/diff/1003/src/pkg/path/filepath/path_test.go File src/pkg/path/filepath/path_test.go (right): http://codereview.appspot.com/6257059/diff/1003/src/pkg/path/filepath/path_test.go#newcode879 src/pkg/path/filepath/path_test.go:879: var tempDir string On 2012/05/29 16:49:22, r wrote: > ...
12 years, 9 months ago (2012-05-29 17:09:15 UTC) #8
rsc
It seems like you can Walk($GOROOT), make the function return SkipDir for "lib", and make ...
12 years, 9 months ago (2012-05-29 17:11:25 UTC) #9
jan_mercl
2012/5/29 Russ Cox <rsc@golang.org>: > It seems like you can Walk($GOROOT), make the function return ...
12 years, 9 months ago (2012-05-29 17:19:31 UTC) #10
jan_mercl
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-05-30 11:02:09 UTC) #11
jan_mercl
2012/5/30 <befelemepeseveze@gmail.com>: > Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), > > Please take another look. > ...
12 years, 9 months ago (2012-05-30 11:06:17 UTC) #12
r
LGTM leaving for rsc. http://codereview.appspot.com/6257059/diff/13001/src/pkg/path/filepath/path.go File src/pkg/path/filepath/path.go (right): http://codereview.appspot.com/6257059/diff/13001/src/pkg/path/filepath/path.go#newcode324 src/pkg/path/filepath/path.go:324: if err != nil && ...
12 years, 9 months ago (2012-05-30 17:44:26 UTC) #13
jan_mercl
http://codereview.appspot.com/6257059/diff/13001/src/pkg/path/filepath/path.go File src/pkg/path/filepath/path.go (right): http://codereview.appspot.com/6257059/diff/13001/src/pkg/path/filepath/path.go#newcode324 src/pkg/path/filepath/path.go:324: if err != nil && (err != SkipDir || ...
12 years, 9 months ago (2012-05-31 12:04:33 UTC) #14
jan_mercl
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-05-31 12:05:11 UTC) #15
rsc
LGTM
12 years, 9 months ago (2012-06-02 16:59:52 UTC) #16
rsc
12 years, 9 months ago (2012-06-02 17:00:13 UTC) #17
*** Submitted as http://code.google.com/p/go/source/detail?r=4ef88bab4b0d ***

path/filepath: implement documented SkipDir behavior

Currently walk() doesn't check for err == SkipDir when iterating
a directory list, but such promise is made in the docs for WalkFunc.

Fixes issue 3486.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/6257059

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b