Issue 6256048: code review 6256048: exp/locale/collate: avoid 16-bit math

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256048: code review 6256048: exp/locale/collate: avoid 16-bit math (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

exp/locale/collate: avoid 16-bit math There's no need for the 16-bit arithmetic here, and it tickles a long-standing compiler bug. Fix the exp code not to use 16-bit math and create an explicit test for the compiler bug.

Patch Set 1 #

Patch Set 2 : diff -r 967ae8baf398 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 967ae8baf398 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	src/pkg/exp/locale/collate/colelem.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	test/bugs/bug440.go	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-24 18:42:34 UTC) #1

rsc

12 years, 9 months ago (2012-05-24 18:50:42 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=67d925cf4352 ***

exp/locale/collate: avoid 16-bit math

There's no need for the 16-bit arithmetic here,
and it tickles a long-standing compiler bug.
Fix the exp code not to use 16-bit math and
create an explicit test for the compiler bug.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6256048

Expand All Messages | Collapse All Messages