Issue 6256045: code review 6256045: exp/html: adjust parseForeignContent to match spec

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256045: code review 6256045: exp/html: adjust parseForeignContent to match spec (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by andybalholm

Modified:
12 years, 9 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

exp/html: adjust parseForeignContent to match spec Remove redundant checks for integration points. Ignore null bytes in text. Don't break out of foreign content for a <font> tag unless it has a color, face, or size attribute. Check for MathML text integration points when breaking out of foreign content. Pass two new tests.

Patch Set 1 #

Patch Set 2 : diff -r 0ed15bfbe0f4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0ed15bfbe0f4 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -16 lines)			Patch
M	src/pkg/exp/html/foreign.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/exp/html/parse.go	View	1	4 chunks	+19 lines, -13 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/plain-text-unsafe.dat.log	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-24 15:31:51 UTC) #1

nigeltao

12 years, 9 months ago (2012-05-25 00:04:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=dd70f64136b7 ***

exp/html: adjust parseForeignContent to match spec

Remove redundant checks for integration points.

Ignore null bytes in text.

Don't break out of foreign content for a <font> tag unless it
has a color, face, or size attribute.

Check for MathML text integration points when breaking out of
foreign content.

Pass two new tests.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6256045

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages