Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(917)

Issue 6236046: code review 6236046: cmd/api: add flag to specify contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by bradfitz
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/api: add flag to specify contexts I needed this to explore per-GOOS/GOARCH differences in pkg syscall for a recent CL. Others may find it useful too.

Patch Set 1 #

Patch Set 2 : diff -r 1098c239b9ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1098c239b9ad https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4c333000f50b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M src/cmd/api/goapi.go View 1 3 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-05-23 20:34:30 UTC) #1
rsc
LGTM
12 years, 9 months ago (2012-05-23 20:38:57 UTC) #2
bradfitz
12 years, 9 months ago (2012-05-23 20:46:14 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=287685288ce1 ***

cmd/api: add flag to specify contexts

I needed this to explore per-GOOS/GOARCH differences in pkg
syscall for a recent CL.  Others may find it useful too.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6236046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b