code review 62360043: runtime: temporary disable concurrent GC sweep

runtime: temporary disable concurrent GC sweep
We see failures on builders, e.g.:
http://build.golang.org/log/70bb28cd6bcf8c4f49810a011bb4337a61977bf4

[rsc, 2014-02-12 19:58:36]

LGTM

[dfc, 2014-02-12 20:00:10]

On 2014/02/12 19:58:36, rsc wrote:
> LGTM

LGTM. Thank you.

[dvyukov, 2014-02-12 20:00:58]

Hello rsc@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2014-02-12 20:03:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=bb13b9997d47 ***

runtime: temporary disable concurrent GC sweep
We see failures on builders, e.g.:
http://build.golang.org/log/70bb28cd6bcf8c4f49810a011bb4337a61977bf4

LGTM=rsc, dave
R=rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/62360043

[gobot, 2014-02-12 20:07:35]

This CL appears to have broken the freebsd-amd64 builder.

[dfc, 2014-02-12 20:13:19]

Please don't ignore this failure, it isn't the usual reflect => SEGV

http://build.golang.org/log/e30674314e895d83e7e0dc055b63ec3703a5ac1b

ok  	regexp/syntax	0.621s
--- FAIL: TestFinalizerType (20.06 seconds)
	mfinal_test.go:62: finalizer for type func(*int) didn't run
	mfinal_test.go:62: finalizer for type func(runtime_test.Tintptr) didn't run
	mfinal_test.go:62: finalizer for type func(*int) didn't run
	mfinal_test.go:62: finalizer for type func(*runtime_test.Tint) didn't run
	mfinal_test.go:62: finalizer for type func(runtime_test.Tinter) didn't run
--- FAIL: TestFinalizerInterfaceBig (4.02 seconds)
	mfinal_test.go:100: finalizer for type *bigValue didn't run
FAIL
FAIL	runtime	39.719s
?   	runtime/cgo	[no test files]
ok  	runtime/debug	0.006s
ok  	runtime/pprof	7.676s
?   	runtime/race	[no test files]
ok  	sort	0.094s
ok  	strconv	0.410s
ok  	strings	0.116s
--- FAIL: TestPoolGC (0.11 seconds)
	pool_test.go:97: only 0 out of 100 resources are finalized
FAIL
FAIL	sync	0.189s



On Thu, Feb 13, 2014 at 7:07 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64 builder.
>
> https://codereview.appspot.com/62360043/
>

[rsc, 2014-02-12 20:45:53]

Yes, this temporary CL does not do enough to restore the world. I am
working on that. Dmitriy is working on the real fix.