Issue 6230047: code review 6230047: go/parser: minor cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6230047: code review 6230047: go/parser: minor cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by gri

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go/parser: minor cleanup - there is no label scope at package level - open/close all scopes symmetrically now that there is only one parse entry point (parseFile)

Patch Set 2 : diff -r 4c05c319570b https://code.google.com/p/go #

Patch Set 3 : diff -r 4c05c319570b https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r fe8549b7050a https://code.google.com/p/go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	src/pkg/go/parser/parser.go	View	1 2 3	4 chunks	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2012-05-22 23:46:10 UTC) #1

LGTM http://codereview.appspot.com/6230047/diff/4002/src/pkg/go/parser/parser.go File src/pkg/go/parser/parser.go (right): http://codereview.appspot.com/6230047/diff/4002/src/pkg/go/parser/parser.go#newcode2313 src/pkg/go/parser/parser.go:2313: assert(p.labelScope == nil, "imbalanced label scopes") the word ...

12 years, 9 months ago (2012-05-23 16:33:53 UTC) #2

gri

12 years, 9 months ago (2012-05-23 16:37:52 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0dc36a693538 ***

go/parser: minor cleanup

- there is no label scope at package level
- open/close all scopes symmetrically now
  that there is only one parse entry point
  (parseFile)

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6230047

Expand All Messages | Collapse All Messages