code review 6221059: net/http: improve TestServerExpect

net/http: improve TestServerExpect

Fail more usefully, and Logf in one place instead of Errorf where
an error is acceptable.

[bradfitz, 2012-05-22 15:26:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-05-22 16:53:10]

LGTM

[bradfitz, 2012-05-22 16:56:37]

You see that this doesn't include the change you proposed, though, right?

Additionally, this CL is missing the fact that reading the 401 denied line
in some cases may fail (if a RST is received).

Is there an easy way to reproduce this failure?  Windows + larger request
body + lots of iterations?  I'm flying a bit blind, but I'm pretty sure I
at least understand the issue now.  I'd still prefer to be able to
reproduce.

On Tue, May 22, 2012 at 9:53 AM, <rsc@golang.org> wrote:

> LGTM
>
>
>
http://codereview.appspot.com/**6221059/<http://codereview.appspot.com/6221059/>
>

[bradfitz, 2012-05-22 17:03:25]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-05-22 17:05:32]

One more revision coming.

On Tue, May 22, 2012 at 10:03 AM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**6221059/<http://codereview.appspot.com/6221059/>
>

[bradfitz, 2012-05-22 17:12:51]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-05-22 17:14:33]

LGTM

http://codereview.appspot.com/6221059/diff/5/src/pkg/net/http/serve_test.go
File src/pkg/net/http/serve_test.go (right):

http://codereview.appspot.com/6221059/diff/5/src/pkg/net/http/serve_test.go#n...
src/pkg/net/http/serve_test.go:687: if test.forcedBadBody() {
I don't think you need this helper.  This is just

if !test.readBody {

[bradfitz, 2012-05-22 17:27:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=2c1cc7b715e6 ***

net/http: improve TestServerExpect

Fail more usefully, and Logf in one place instead of Errorf where
an error is acceptable.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6221059