code review 6220073: cmd/ld: fix Linux/ARM build

cmd/ld: fix Linux/ARM build
        CL 5823055 removed a line introduced in Linux/ARM cgo support.
        Because readsym() now returns nil for "$a", "$d" mapping symbols,
        no matter the settings of `needSym', we still have to guard against
        them in ldelf().

[minux1, 2012-05-23 02:59:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2012-05-23 03:24:27]

This worked for me on ARM5 and ARM7.

[dave_cheney.net, 2012-05-23 03:24:35]

LGTM

[rsc, 2012-05-23 03:25:47]

LGTM

please put the comment above the if on a line by itself.
the line is kind of long

[minux1, 2012-05-23 03:30:59]

On Wed, May 23, 2012 at 11:25 AM, Russ Cox <rsc@golang.org> wrote:

> please put the comment above the if on a line by itself.
> the line is kind of long
>
I've changed the line to be more generic, guarding the sym.sym == S
condition
so that even we change readsym to ignore other symbols, the code here won't
break again.

[minux1, 2012-05-23 03:36:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=9e5ed0741dc8 ***

cmd/ld: fix Linux/ARM build
        CL 5823055 removed a line introduced in Linux/ARM cgo support.
        Because readsym() now returns nil for "$a", "$d" mapping symbols,
        no matter the settings of `needSym', we still have to guard against
        them in ldelf().

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6220073