Issue 6220062: code review 6220062: exp/html: adjust inSelectIM to match spec

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6220062: code review 6220062: exp/html: adjust inSelectIM to match spec (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by andybalholm

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc, nigeltao

Visibility:
Public.

Description

exp/html: adjust inSelectIM to match spec Simplify the flow of control. Handle EOF, null bytes, <html>, <input>, <keygen>, <textarea>, <script>. Pass 5 more tests.

Patch Set 1 #

Patch Set 2 : diff -r 4cf98a732e92 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4cf98a732e92 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -34 lines)			Patch
M	src/pkg/exp/html/parse.go	View	1	7 chunks	+27 lines, -29 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests18.dat.log	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests7.dat.log	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

andybalholm

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, nigeltao@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-22 03:56:58 UTC) #1

nigeltao

On 22 May 2012 14:17, <dsymonds@golang.org> wrote: > R=nigeltao Andy, when you "hg mail", please ...

12 years, 9 months ago (2012-05-22 05:23:38 UTC) #2

rsc

On Tue, May 22, 2012 at 1:23 AM, Nigel Tao <nigeltao@golang.org> wrote: > Andy, when ...

12 years, 9 months ago (2012-05-22 05:25:01 UTC) #3

nigeltao

12 years, 9 months ago (2012-05-22 05:30:38 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=da5b554f6ea6 ***

exp/html: adjust inSelectIM to match spec

Simplify the flow of control.

Handle EOF, null bytes, <html>, <input>, <keygen>, <textarea>, <script>.

Pass 5 more tests.

R=golang-dev, rsc, nigeltao
CC=golang-dev
http://codereview.appspot.com/6220062

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages