Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1019)

Issue 6220050: code review 6220050: A+C: b@b3k.us (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by agl1
Modified:
12 years, 10 months ago
Reviewers:
iant2
CC:
golang-dev, r
Visibility:
Public.

Description

A+C: b@b3k.us

Patch Set 1 #

Patch Set 2 : diff -r 85e153815747 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 85e153815747 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 85e153815747 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 85e153815747 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M CONTRIBUTORS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 10 months ago (2012-05-18 14:58:10 UTC) #1
r
LGTM
12 years, 10 months ago (2012-05-18 15:03:32 UTC) #2
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=f0a9aa408d21 *** A+C: b@b3k.us R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6220050
12 years, 10 months ago (2012-05-18 15:04:55 UTC) #3
iant2
12 years, 10 months ago (2012-05-18 15:54:21 UTC) #4
LGTM

Before submitting, please add "(individual CLA)" to CL description.

Ian

agl@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> A+C: b@b3k.us
>
> Please review this at http://codereview.appspot.com/6220050/
>
> Affected files:
>   M AUTHORS
>   M CONTRIBUTORS
>
>
> Index: AUTHORS
> ===================================================================
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -31,6 +31,7 @@
>  Aron Nopanen <aron.nopanen@gmail.com>
>  Arvindh Rajesh Tamilmani <art@a-30.net>
>  Ben Olive <sionide21@gmail.com>
> +Benjamin Black <b@b3k.us>
>  Benny Siegert <bsiegert@gmail.com>
>  Berengar Lehr <berengar.lehr@gmx.de>
>  Brian Dellisanti <briandellisanti@gmail.com>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -64,6 +64,7 @@
>  Ben Fried <ben.fried@gmail.com>
>  Ben Lynn <benlynn@gmail.com>
>  Ben Olive <sionide21@gmail.com>
> +Benjamin Black <b@b3k.us>
>  Benny Siegert <bsiegert@gmail.com>
>  Berengar Lehr <Berengar.Lehr@gmx.de>
>  Bill Neubauer <wcn@golang.org> <wcn@google.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b