code review 6218050: runtime: relax TestGcSys

runtime: relax TestGcSys

This fixes occasional 64-bit failures.
Maybe it will fix the 32-bit failures too,
so re-enable on 32-bit for now.

[rsc, 2012-05-18 17:12:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-05-18 17:13:48]

LGTM

On Fri, May 18, 2012 at 10:12 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: relax TestGcSys
>
> This fixes occasional 64-bit failures.
> Maybe it will fix the 32-bit failures too,
> so re-enable on 32-bit for now.
>
> Please review this at
http://codereview.appspot.com/**6218050/<http://codereview.appspot.com/6218050/>
>
> Affected files:
>  M src/pkg/runtime/gc_test.go
>
>
> Index: src/pkg/runtime/gc_test.go
> ==============================**==============================**=======
> --- a/src/pkg/runtime/gc_test.go
> +++ b/src/pkg/runtime/gc_test.go
> @@ -10,11 +10,6 @@
>  )
>
>  func TestGcSys(t *testing.T) {
> -       if runtime.GOARCH != "amd64" {
> -               // TODO(adg): remove this when precise gc is implemented
> -               t.Logf("skipping on non-amd64 systems")
> -               return
> -       }
>        memstats := new(runtime.MemStats)
>        runtime.GC()
>        runtime.ReadMemStats(memstats)
> @@ -31,6 +26,7 @@
>        }
>
>        // Should only be using a few MB.
> +       // We allocated 100 MB or (if not short) 1 GB.
>        runtime.ReadMemStats(memstats)
>        if sys > memstats.Sys {
>                sys = 0
> @@ -38,7 +34,7 @@
>                sys = memstats.Sys - sys
>        }
>        t.Logf("used %d extra bytes", sys)
> -       if sys > 4<<20 {
> +       if sys > 16<<20 {
>                t.Fatalf("using too much memory: %d bytes", sys)
>        }
>  }
>
>
>

[r, 2012-05-18 17:14:58]

LGTM

[dvyukov, 2012-05-19 10:17:50]

On 2012/05/18 17:12:21, rsc wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

LGTM

[rsc, 2012-05-22 04:07:19]

*** Submitted as http://code.google.com/p/go/source/detail?r=68f039bd4799 ***

runtime: relax TestGcSys

This fixes occasional 64-bit failures.
Maybe it will fix the 32-bit failures too,
so re-enable on 32-bit for now.

R=golang-dev, bradfitz, r, dvyukov
CC=golang-dev
http://codereview.appspot.com/6218050