Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(593)

Issue 6217045: code review 6217045: go spec: clarify promotion rules for methods/fields of ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by gri
Modified:
12 years, 9 months ago
Reviewers:
CC:
rsc, r, iant, kevlar, iant2, golang-dev
Visibility:
Public.

Description

go spec: clarify promotion rules for methods/fields of anonymous fields Fixes issue 3635.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r d263b323e582 https://code.google.com/p/go #

Patch Set 3 : diff -r 820ffde8c396 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r e92c07f19c3a https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r d34e1877830c https://code.google.com/p/go #

Patch Set 6 : diff -r d34e1877830c https://code.google.com/p/go #

Total comments: 6

Patch Set 7 : diff -r d34e1877830c https://code.google.com/p/go #

Patch Set 8 : diff -r d34e1877830c https://code.google.com/p/go #

Patch Set 9 : diff -r d34e1877830c https://code.google.com/p/go #

Patch Set 10 : diff -r 5eb6fe483779 https://code.google.com/p/go #

Total comments: 10

Patch Set 11 : diff -r 85022208a2aa https://code.google.com/p/go #

Total comments: 3

Patch Set 12 : diff -r 685b1b62a34f https://code.google.com/p/go #

Patch Set 13 : diff -r 1b8e032d6ad6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 29
gri
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 10 months ago (2012-05-17 20:22:56 UTC) #1
r
LGTM
12 years, 10 months ago (2012-05-17 20:47:01 UTC) #2
rsc
LGTM
12 years, 10 months ago (2012-05-17 20:56:47 UTC) #3
iant
FYI http://codereview.appspot.com/6217045/diff/1/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/1/doc/go_spec.html#newcode958 doc/go_spec.html:958: <a href="#Method_declarations">Methods</a> of an anonymous field are promoted ...
12 years, 10 months ago (2012-05-17 21:14:48 UTC) #4
gri
Arguably what there is now is better than what there was before. I agree that ...
12 years, 10 months ago (2012-05-17 21:20:00 UTC) #5
rsc
On Thu, May 17, 2012 at 5:14 PM, <iant@golang.org> wrote: > As long as we're ...
12 years, 10 months ago (2012-05-17 21:23:25 UTC) #6
kevlar
To me, the term "promotion" is also ambiguous because it seems to imply that it's ...
12 years, 10 months ago (2012-05-17 21:27:45 UTC) #7
iant2
Robert Griesemer <gri@golang.org> writes: > Arguably what there is now is better than what there ...
12 years, 10 months ago (2012-05-17 23:20:57 UTC) #8
gri
PTAL. The previous version - while better than what was there originally - was still ...
12 years, 10 months ago (2012-05-18 00:51:43 UTC) #9
kevlar
http://codereview.appspot.com/6217045/diff/9001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/9001/doc/go_spec.html#newcode683 doc/go_spec.html:683: consists of all methods with receiver type <code>T</code>. Maybe: ...
12 years, 10 months ago (2012-05-18 22:40:21 UTC) #10
gri
PTAL. - gri On Fri, May 18, 2012 at 3:40 PM, <kevlar@google.com> wrote: > > ...
12 years, 10 months ago (2012-05-19 00:54:55 UTC) #11
r
http://codereview.appspot.com/6217045/diff/12002/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/12002/doc/go_spec.html#newcode688 doc/go_spec.html:688: containing anonymous fields. 'additional rules apply' should be supplemented ...
12 years, 10 months ago (2012-05-20 00:45:49 UTC) #12
gri
PTAL. Emphasized the notion of "promoted" method and field. Hopefully made this clear now. - ...
12 years, 9 months ago (2012-05-31 21:33:39 UTC) #13
kevlar
http://codereview.appspot.com/6217045/diff/19001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/19001/doc/go_spec.html#newcode962 doc/go_spec.html:962: struct, are <i>promoted</i> to be ordinary fields and methods ...
12 years, 9 months ago (2012-05-31 23:04:35 UTC) #14
gri
PTAL http://codereview.appspot.com/6217045/diff/19001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/19001/doc/go_spec.html#newcode962 doc/go_spec.html:962: struct, are <i>promoted</i> to be ordinary fields and ...
12 years, 9 months ago (2012-05-31 23:34:56 UTC) #15
kevlar
LGTM
12 years, 9 months ago (2012-06-01 00:05:09 UTC) #16
gri
Any others? - gri On Thu, May 31, 2012 at 5:05 PM, <kevlar@google.com> wrote: > ...
12 years, 9 months ago (2012-06-04 16:49:59 UTC) #17
r
http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of June 1, 2012", 4 http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html#newcode965 doc/go_spec.html:965: ...
12 years, 9 months ago (2012-06-04 17:16:22 UTC) #18
rsc
http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html#newcode976 doc/go_spec.html:976: (the <i>promoted method set</i> of <code>T</code>). This is not ...
12 years, 9 months ago (2012-06-04 17:27:00 UTC) #19
gri
PTAL http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/26001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of June 1, 2012", On 2012/06/04 ...
12 years, 9 months ago (2012-06-04 18:23:57 UTC) #20
rsc
LGTM but wait for r
12 years, 9 months ago (2012-06-04 18:40:01 UTC) #21
r
http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html#newcode970 doc/go_spec.html:970: promoted methods are included in the method set of ...
12 years, 9 months ago (2012-06-04 18:43:31 UTC) #22
gri
http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html#newcode970 doc/go_spec.html:970: promoted methods are included in the method set of ...
12 years, 9 months ago (2012-06-04 19:56:17 UTC) #23
r
http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6217045/diff/32001/doc/go_spec.html#newcode970 doc/go_spec.html:970: promoted methods are included in the method set of ...
12 years, 9 months ago (2012-06-04 20:47:44 UTC) #24
iant
LGTM
12 years, 9 months ago (2012-06-04 20:57:16 UTC) #25
gri
PTAL. Incorporated some changes per r's suggestion. - gri On Mon, Jun 4, 2012 at ...
12 years, 9 months ago (2012-06-04 21:09:45 UTC) #26
r
LGTM yay
12 years, 9 months ago (2012-06-04 21:11:40 UTC) #27
rsc
LGTM
12 years, 9 months ago (2012-06-04 21:12:34 UTC) #28
gri
12 years, 9 months ago (2012-06-04 21:24:29 UTC) #29
*** Submitted as http://code.google.com/p/go/source/detail?r=ae0301294b9b ***

go spec: clarify promotion rules for methods/fields of anonymous fields

Fixes issue 3635.

R=rsc, r, iant, kevlar, iant
CC=golang-dev
http://codereview.appspot.com/6217045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b