Issue 6213064: code review 6213064: net/http: fix response Connection: close, close client ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6213064: code review 6213064: net/http: fix response Connection: close, close client ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, niemeyer

Visibility:
Public.

Description

net/http: fix response Connection: close, close client connections Fixes issue 3663 Updates issue 3540 (fixes it more) Updates issue 1967 (fixes it more, re-enables a test)

Patch Set 2 : diff -r fa807f847959 https://go.googlecode.com/hg #

Patch Set 3 : diff -r fa807f847959 https://go.googlecode.com/hg #

Patch Set 4 : diff -r fa807f847959 https://go.googlecode.com/hg #

Total comments: 4

Patch Set 5 : diff -r 0dc36a693538 https://go.googlecode.com/hg #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -16 lines)			Patch
M	src/pkg/net/http/serve_test.go	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	src/pkg/net/http/server.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1 2 3 4	5 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

11 years, 11 months ago (2012-05-22 20:55:36 UTC) #1

niemeyer

LGTM http://codereview.appspot.com/6213064/diff/6005/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): http://codereview.appspot.com/6213064/diff/6005/src/pkg/net/http/server.go#newcode310 src/pkg/net/http/server.go:310: if w.header.Get("Connection") == "close" { Should this use ...

11 years, 11 months ago (2012-05-23 17:40:04 UTC) #2

bradfitz

http://codereview.appspot.com/6213064/diff/6005/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): http://codereview.appspot.com/6213064/diff/6005/src/pkg/net/http/server.go#newcode310 src/pkg/net/http/server.go:310: if w.header.Get("Connection") == "close" { On 2012/05/23 17:40:05, niemeyer ...

11 years, 11 months ago (2012-05-23 18:13:52 UTC) #3

bradfitz

11 years, 11 months ago (2012-05-23 18:19:46 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=4c333000f50b ***

net/http: fix response Connection: close, close client connections

Fixes issue 3663
Updates issue 3540 (fixes it more)
Updates issue 1967 (fixes it more, re-enables a test)

R=golang-dev, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/6213064

Expand All Messages | Collapse All Messages