code review 6210062: runtime: disable gc test on non-amd64 systems

runtime: disable gc test on non-amd64 systems

[adg, 2012-05-17 01:28:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc, 2012-05-17 01:30:34]

LGTM

[adg, 2012-05-17 01:34:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=4151d4de5a04 ***

runtime: disable gc test on non-amd64 systems

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6210062

[cw, 2012-05-17 03:24:37]

>  func TestGcSys(t *testing.T) {
> +	if runtime.GOARCH != "amd64" {
> +		// TODO(adg): remove this when precise gc is implemented
> +		t.Logf("skipping on non-amd64 systems")
> +		return
> +	}

does gccgo use these tests?

[iant2, 2012-05-17 04:25:13]

Chris Wedgwood <cw@f00f.org> writes:

>>  func TestGcSys(t *testing.T) {
>> +	if runtime.GOARCH != "amd64" {
>> +		// TODO(adg): remove this when precise gc is implemented
>> +		t.Logf("skipping on non-amd64 systems")
>> +		return
>> +	}
>
> does gccgo use these tests?

Yes, I periodically copy the gc testsuite over to gccgo.  I don't mind
disabling this test, though.

Ian