Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(910)

Issue 6209048: code review 6209048: runtime: fix syscalls for netbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by jsing
Modified:
12 years, 10 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: fix syscalls for netbsd Use correct syscall numbers and arguments for NetBSD. Provide a trampoline for signal returns (using signal API 3).

Patch Set 1 #

Patch Set 2 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r eba9981e6eb7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M src/pkg/runtime/sys_netbsd_386.s View 1 3 chunks +23 lines, -4 lines 0 comments Download
M src/pkg/runtime/sys_netbsd_amd64.s View 1 2 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-05-10 15:01:01 UTC) #1
rsc
Exiting silently is a bad way to react to an unexpected failure. Better to do ...
12 years, 10 months ago (2012-05-10 15:30:11 UTC) #2
jsing
On 2012/05/10 15:30:11, rsc wrote: > Exiting silently is a bad way to react to ...
12 years, 10 months ago (2012-05-10 16:54:56 UTC) #3
rsc
LGTM
12 years, 10 months ago (2012-05-10 17:12:07 UTC) #4
jsing
12 years, 10 months ago (2012-05-10 17:48:52 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f359827334f4 ***

runtime: fix syscalls for netbsd

Use correct syscall numbers and arguments for NetBSD.
Provide a trampoline for signal returns (using signal API 3).

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6209048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b