Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11418)

Issue 6208076: code review 6208076: crypto/rsa: add SHA-224 hash prefix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rsc
Modified:
11 years, 11 months ago
Reviewers:
CC:
golang-dev, agl1
Visibility:
Public.

Description

crypto/rsa: add SHA-224 hash prefix http://www.rsa.com/rsalabs/node.asp?id=2125: NOTE: A new OID has been defined for the combination of the v1.5 signature scheme and the SHA-224 hash function: sha224WithRSAEncryption OBJECT IDENTIFIER ::= Like the other sha*WithRSAEncryption OIDs in PKCS #1 v2.1, this OID has NULL parameters. The DigestInfo encoding for SHA-224 (see Section 9.2, Note 1) is: (0x)30 2d 30 0d 06 09 60 86 48 01 65 03 04 02 04 05 00 04 1c || H

Patch Set 1 #

Patch Set 2 : diff -r ffac49bf1058 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ffac49bf1058 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ffac49bf1058 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r aad801637707 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/crypto/rsa/pkcs1v15.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 11 months ago (2012-05-17 23:48:56 UTC) #1
rsc
R=agl This is untested, although I have some private code that I plan to check ...
11 years, 11 months ago (2012-05-17 23:50:13 UTC) #2
agl1
LGTM
11 years, 11 months ago (2012-05-18 01:11:37 UTC) #3
rsc
Confirmed against OpenSSL. Submitting.
11 years, 11 months ago (2012-05-21 18:10:19 UTC) #4
rsc
11 years, 11 months ago (2012-05-21 18:10:21 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=c6213d8a9118 ***

crypto/rsa: add SHA-224 hash prefix

http://www.rsa.com/rsalabs/node.asp?id=2125:

NOTE: A new OID has been defined for the combination
of the v1.5 signature scheme and the SHA-224 hash function:
        sha224WithRSAEncryption OBJECT IDENTIFIER ::=
Like the other sha*WithRSAEncryption OIDs in PKCS #1 v2.1,
this OID has NULL parameters.
The DigestInfo encoding for SHA-224 (see Section 9.2, Note 1) is:
        (0x)30 2d 30 0d 06 09 60 86 48 01 65 03 04 02 04 05 00 04 1c || H

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6208076
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b