Issue 6208057: code review 6208057: sync: use atomic.Store in Once.Do

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6208057: code review 6208057: sync: use atomic.Store in Once.Do (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by dvyukov

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

sync: use atomic.Store in Once.Do No perf/semantic changes, merely improves code health. There were several questions as to why Once.Do uses atomic.CompareAndSwap to do a store.

Patch Set 1 #

Patch Set 2 : diff -r 3b1efbd100bb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3b1efbd100bb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 3b1efbd100bb https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/sync/once.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 10 months ago (2012-05-14 14:53:04 UTC) #1

dvyukov

12 years, 10 months ago (2012-05-14 15:27:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9184ffa5fa13 ***

sync: use atomic.Store in Once.Do
No perf/semantic changes, merely improves code health.
There were several questions as to why Once.Do uses
atomic.CompareAndSwap to do a store.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6208057

Expand All Messages | Collapse All Messages