code review 6206093: exp/html: adjust inCellIM to match spec

exp/html: adjust inCellIM to match spec

Clean up flow of control.

Ignore </table>, </tbody>, </tfoot>, </thead>, </tr> if there is not
an appropriate element in table scope.

Pass 3 more tests.

[andybalholm, 2012-05-21 17:46:26]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
nigeltao@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2012-05-22 00:30:18]

LGTM, and submitting, but I'm curious about the unconditional popUntil.

http://codereview.appspot.com/6206093/diff/5001/src/pkg/exp/html/parse.go
File src/pkg/exp/html/parse.go (right):

http://codereview.appspot.com/6206093/diff/5001/src/pkg/exp/html/parse.go#new...
src/pkg/exp/html/parse.go:1492: p.popUntil(tableScope, "td", "th")
Should this be
if p.popUntil(etc) {
  // etc
}
// Ignore the token.
return true

[nigeltao, 2012-05-22 00:31:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=3ce27769ca65 ***

exp/html: adjust inCellIM to match spec

Clean up flow of control.

Ignore </table>, </tbody>, </tfoot>, </thead>, </tr> if there is not
an appropriate element in table scope.

Pass 3 more tests.

R=golang-dev, nigeltao
CC=golang-dev
http://codereview.appspot.com/6206093

Committer: Nigel Tao <nigeltao@golang.org>

[andybalholm, 2012-05-22 03:15:30]

http://codereview.appspot.com/6206093/diff/5001/src/pkg/exp/html/parse.go
File src/pkg/exp/html/parse.go (right):

http://codereview.appspot.com/6206093/diff/5001/src/pkg/exp/html/parse.go#new...
src/pkg/exp/html/parse.go:1492: p.popUntil(tableScope, "td", "th")
The spec says:

The stack of open elements cannot have both a td and a th element in table scope
at the same time, nor can it have neither when the close the cell algorithm is
invoked.

If this is true, popUntil will always return true here.