Issue 6206090: code review 6206090: net/url: better parsing of urls with @ symbol in authority

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6206090: code review 6206090: net/url: better parsing of urls with @ symbol in authority (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by snaury

Modified:
11 years, 12 months ago

Reviewers:

CC:
r, rsc, dsymonds, niemeyer, golang-dev

Visibility:
Public.

Description

net/url: better parsing of urls with @ symbol in authority Fixes issue 3439

Patch Set 1 #

Patch Set 2 : diff -r b0dd97867c83 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b0dd97867c83 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c7cbeae11662 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	src/pkg/net/url/url.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	src/pkg/net/url/url_test.go	View	1 2 3	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

snaury

Hello r@golang.org, rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2012-05-20 08:10:57 UTC) #1

snaury

Please review my change. Come to think of it, I'm separating tests with and without ...

12 years ago (2012-05-21 17:16:28 UTC) #2

snaury

Hello r@golang.org, rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years ago (2012-05-21 17:37:48 UTC) #3

niemeyer

LGTM, thanks. It's an invalid URL according to the RFC, but given that the most ...

11 years, 12 months ago (2012-05-22 11:37:46 UTC) #5

rsc

11 years, 12 months ago (2012-05-22 16:44:34 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=89a9ef95c8db ***

net/url: better parsing of urls with @ symbol in authority

Fixes issue 3439

R=r, rsc, dsymonds, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/6206090

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages