Issue 6203091: code review 6203091: cmd/6g: peephole fixes/additions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6203091: code review 6203091: cmd/6g: peephole fixes/additions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/6g: peephole fixes/additions * Shift/rotate by constant doesn't have to stop subprop. (also in 8g) * Remove redundant MOVLQZX instructions. * An attempt at issuing loads early. Good for 0.5% on a good day, might not be worth keeping. Need to understand more about whether the x86 looks ahead to what loads might be coming up.

Patch Set 1 #

Patch Set 2 : diff -r ffac49bf1058 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ffac49bf1058 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r aa2d2fa1e5a9 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -26 lines)			Patch
	M	src/cmd/6g/peep.c	View	1	6 chunks	+172 lines, -15 lines	0 comments	Download
	M	src/cmd/8g/peep.c	View	1 2	2 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-05-18 00:26:44 UTC) #1

rsc

12 years, 9 months ago (2012-05-24 16:11:38 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=3b320ce16e39 ***

cmd/6g: peephole fixes/additions

* Shift/rotate by constant doesn't have to stop subprop. (also in 8g)
* Remove redundant MOVLQZX instructions.
* An attempt at issuing loads early.
  Good for 0.5% on a good day, might not be worth keeping.
  Need to understand more about whether the x86
  looks ahead to what loads might be coming up.

R=ken2, ken
CC=golang-dev
http://codereview.appspot.com/6203091

Expand All Messages | Collapse All Messages