Issue 6202043: code review 6202043: runtime: fix build for Linux/ARM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6202043: code review 6202043: runtime: fix build for Linux/ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by minux1

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

runtime, misc/cgo/test: fix build for Linux/ARM 1. In CL 5989057, I made a mistake in the last minute change. "MOVW.W R4, -4(SP)" should really be "MOVW.W R4, -4(R13)", as 5l will rewrite offset for SP. 2. misc/cgo/test/issue1560.go tests for parallel sleep of 1s, but on ARM, the deadline is frequently missed, so change sleep time to 2s on ARM.

Patch Set 1 #

Patch Set 2 : diff -r 9233f811c522 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9233f811c522 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9233f811c522 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 7873186d5774 https://code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	misc/cgo/test/issue1560.go	View	1 2 3	2 chunks	+11 lines, -4 lines	0 comments	Download
	M	src/pkg/runtime/asm_arm.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 10 months ago (2012-05-04 11:53:34 UTC) #1

minux1

PTAL. Also relaxed the misc/cgo/test a bit so that it won't accidentally break on ARM. ...

12 years, 10 months ago (2012-05-04 15:12:10 UTC) #4

minux1

12 years, 10 months ago (2012-05-04 17:35:44 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=16fcd7235fad ***

runtime, misc/cgo/test: fix build for Linux/ARM
1. In CL 5989057, I made a mistake in the last minute change.
"MOVW.W R4, -4(SP)" should really be "MOVW.W R4, -4(R13)",
as 5l will rewrite offset for SP.
2. misc/cgo/test/issue1560.go tests for parallel sleep of 1s,
but on ARM, the deadline is frequently missed, so change sleep
time to 2s on ARM.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6202043

Expand All Messages | Collapse All Messages