Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(439)

Issue 6197061: code review 6197061: compress/testdata: remove Byte Order Mark from the Tom ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by nigeltao
Modified:
12 years, 10 months ago
Reviewers:
CC:
r, bradfitz, golang-dev, Ivan Krasin, rsc
Visibility:
Public.

Description

compress/testdata: remove Byte Order Mark from the Tom Sawyer data. I'm not sure where the BOM came from, originally. http://www.gutenberg.org/files/74/74.txt doesn't have it, although a fresh download of that URL gives me "\r\n"s instead of plain "\n"s, and the extra line "Character set encoding: ASCII". Maybe Project Gutenberg has changed their server configuration since we added that file to the Go repo. Anyway, this change is just manually excising the BOM from the start of the file, leaving pure ASCII.

Patch Set 1 #

Patch Set 2 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d4f7f7438d1f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/compress/testdata/Mark.Twain-Tom.Sawyer.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com, krasin@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-05-08 00:35:22 UTC) #1
bradfitz
LGTM On Tue, May 8, 2012 at 10:35 AM, <nigeltao@golang.org> wrote: > Reviewers: r, > ...
12 years, 10 months ago (2012-05-08 00:37:54 UTC) #2
nigeltao
12 years, 10 months ago (2012-05-08 00:41:57 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=8db1b9223486 ***

compress/testdata: remove Byte Order Mark from the Tom Sawyer data.

I'm not sure where the BOM came from, originally.
http://www.gutenberg.org/files/74/74.txt doesn't have it, although
a fresh download of that URL gives me "\r\n"s instead of plain "\n"s,
and the extra line "Character set encoding: ASCII". Maybe Project
Gutenberg has changed their server configuration since we added that
file to the Go repo.

Anyway, this change is just manually excising the BOM from the start
of the file, leaving pure ASCII.

R=r, bradfitz
CC=golang-dev, krasin, rsc
http://codereview.appspot.com/6197061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b