Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 6194064: code review 6194064: syscall: repair netbsd z* files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by jsing
Modified:
12 years, 10 months ago
Reviewers:
CC:
golang-dev, rsc, minux1
Visibility:
Public.

Description

syscall: repair netbsd z* files Manually repair/update z* files for netbsd - this allows Go to compile again on 386.

Patch Set 1 #

Patch Set 2 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -67 lines) Patch
M src/pkg/syscall/zerrors_netbsd_386.go View 1 3 chunks +73 lines, -33 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_amd64.go View 1 2 chunks +37 lines, -33 lines 0 comments Download
M src/pkg/syscall/zsyscall_netbsd_386.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-05-10 14:51:32 UTC) #1
rsc
LGTM If they're not machine generated, do you want to fix the comments at the ...
12 years, 10 months ago (2012-05-10 14:53:41 UTC) #2
jsing
On 2012/05/10 14:53:41, rsc wrote: > LGTM > > If they're not machine generated, do ...
12 years, 10 months ago (2012-05-10 16:48:47 UTC) #3
minux1
On Fri, May 11, 2012 at 12:48 AM, <jsing@google.com> wrote: > On 2012/05/10 14:53:41, rsc ...
12 years, 10 months ago (2012-05-10 16:53:45 UTC) #4
jsing
12 years, 10 months ago (2012-05-10 17:47:41 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a50bbdc9c751 ***

syscall: repair netbsd z* files

Manually repair/update z* files for netbsd - this allows Go to
compile again on 386.

R=golang-dev, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6194064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b