code review 61720044: debug/macho: add test file for CL 60190043

debug/macho: add test file for CL 60190043

From the description of CL 60190043

debug/macho: Add support for opening fat/universal binaries.

New testdata was created from existing using:
$ lipo gcc-386-darwin-exec gcc-amd64-darwin-exec -create -output
fat-gcc-386-amd64-darwin-exec

Update issue 7250

[dave_cheney.net, 2014-02-11 03:22:40]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2014-02-12 22:43:12]

R=dsymonds@golang.org (assigned by dave@cheney.net)

[dsymonds, 2014-02-12 22:44:52]

I'm not really all that macho, nor a Dwarf. Someone else would be a better
reviewer.

[dave_cheney.net, 2014-02-12 22:46:38]

I just need someone to LGTM this change which is just the fixture that Rietveld
barfed on the in main CL. 

I'll do you a return solid with your archive/tar issue. 

> On 13 Feb 2014, at 9:44, dsymonds@golang.org wrote:
> 
> I'm not really all that macho, nor a Dwarf. Someone else would be a
> better reviewer.
> 
> https://codereview.appspot.com/61720044/

[iant, 2014-02-12 22:50:33]

Can you add a note somewhere about how this file was built?  I guess in the CL
description if nowhere else.  Maybe we need README files in our testdata
directories that contain binaries.  Thanks.

I don't actually know what "fixture" means here.

[dave_cheney.net, 2014-02-12 22:52:35]

On 2014/02/12 22:46:38, dfc wrote:
> I just need someone to LGTM this change which is just the fixture that
Rietveld
> barfed on the in main CL. 
> 
> I'll do you a return solid with your archive/tar issue. 
> 
> > On 13 Feb 2014, at 9:44, mailto:dsymonds@golang.org wrote:
> > 
> > I'm not really all that macho, nor a Dwarf. Someone else would be a
> > better reviewer.
> > 
> > https://codereview.appspot.com/61720044/

This is the test file from CL https://codereview.appspot.com/60190043/ that
could not be submitted. The author reverted it from the original CL and I've
been able to make a new CL with just the file.

[iant, 2014-02-12 23:20:06]

On Wed, Feb 12, 2014 at 2:52 PM,  <dave@cheney.net> wrote:
> On 2014/02/12 22:46:38, dfc wrote:
>>
>> I just need someone to LGTM this change which is just the fixture that
>
> Rietveld
>>
>> barfed on the in main CL.
>
>
>> I'll do you a return solid with your archive/tar issue.
>
>
>> > On 13 Feb 2014, at 9:44, mailto:dsymonds@golang.org wrote:
>> >
>> > I'm not really all that macho, nor a Dwarf. Someone else would be a
>> > better reviewer.
>> >
>> > https://codereview.appspot.com/61720044/
>
>
> This is the test file from CL https://codereview.appspot.com/60190043/
> that could not be submitted. The author reverted it from the original CL
> and I've been able to make a new CL with just the file.

OK--can you copy the description from that CL to this one, so that it
is attached to the right file?  Thanks.

Ian

[dave_cheney.net, 2014-02-12 23:47:33]

Hello golang-codereviews@googlegroups.com, gobot@golang.org,
dsymonds@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-02-12 23:56:35]

LGTM

Thanks.

[dave_cheney.net, 2014-02-12 23:57:51]

Thanks. Once this is submitted I think I might take a crack at finding a
better way to handle these binaries, the current solution is too costly.


On Thu, Feb 13, 2014 at 10:56 AM, <iant@golang.org> wrote:

> LGTM
>
> Thanks.
>
>
> https://codereview.appspot.com/61720044/
>

[dave_cheney.net, 2014-02-12 23:58:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=1c3017e17146 ***

debug/macho: add test file for CL 60190043

From the description of CL 60190043

debug/macho: Add support for opening fat/universal binaries.

New testdata was created from existing using:
$ lipo gcc-386-darwin-exec gcc-amd64-darwin-exec -create -output
fat-gcc-386-amd64-darwin-exec

Update issue 7250

LGTM=iant
R=golang-codereviews, gobot, dsymonds, iant
CC=golang-codereviews
https://codereview.appspot.com/61720044