Issue 61690044: code review 61690044: ogle: fix A+C so we don't need to maintain contributors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61690044: code review 61690044: ogle: fix A+C so we don't need to maintain contributors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by r

Modified:
10 years, 2 months ago

Reviewers:
rsc

CC:
rsc, nigeltao

Visibility:
Public.

Description

ogle: fix A+C so we don't need to maintain contributors Put coderefview.cfg in the root and copy it, plus A+C from go.tools. Drop the defaultcc: line from codereview.cfg, at least for now.

Patch Set 1 #

Patch Set 2 : diff -r 491eb7565e88 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -19 lines)			Patch
M	AUTHORS	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	CONTRIBUTORS	View	1 chunk	+0 lines, -10 lines	0 comments	Download
A	codereview.cfg	View	1 chunk	+1 line, -0 lines	0 comments	Download
R	lib/codereview/codereview.cfg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: nigeltao), I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-10 21:53:05 UTC) #1

10 years, 2 months ago (2014-02-10 22:15:35 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=e53db6031eee ***

ogle: fix A+C so we don't need to maintain contributors
Put coderefview.cfg in the root and copy it, plus A+C from go.tools.
Drop the defaultcc: line from codereview.cfg, at least for now.

LGTM=rsc
R=rsc
CC=nigeltao
https://codereview.appspot.com/61690044

Expand All Messages | Collapse All Messages