Issue 6167044: code review 6167044: exp/locale/collate: Add maketables tool and generated t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6167044: code review 6167044: exp/locale/collate: Add maketables tool and generated t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by mpvl

Modified:
12 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

exp/locale/collate: Add maketables tool and generated tables. Also set maxContractLen automatically. Note that the table size is much bigger than it needs to be. Optimization is best done, though, when the language specific tables are added.

Patch Set 1 #

Patch Set 2 : diff -r bc9a5c0eb13c https://go.googlecode.com/hg #

Patch Set 3 : diff -r bc9a5c0eb13c https://go.googlecode.com/hg #

Patch Set 4 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg #

Patch Set 5 : diff -r adc987ffdd99 https://go.googlecode.com/hg #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7477 lines, -4 lines)			Patch
A	src/pkg/exp/locale/collate/Makefile	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/exp/locale/collate/build/builder.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/exp/locale/collate/build/table.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/exp/locale/collate/collate.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
A	src/pkg/exp/locale/collate/maketables.go	View	1	1 chunk	+185 lines, -0 lines	0 comments	Download
A	src/pkg/exp/locale/collate/tables.go	View	1 2	1 chunk	+7272 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

12 years, 10 months ago (2012-05-07 09:56:50 UTC) #1

mpvl

12 years, 10 months ago (2012-05-09 10:04:05 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9182664c616f ***

exp/locale/collate: Add maketables tool and generated tables.
Also set maxContractLen automatically.
Note that the table size is much bigger than it needs to be.
Optimization is best done, though, when the language specific
tables are added.

R=r
CC=golang-dev
http://codereview.appspot.com/6167044

Expand All Messages | Collapse All Messages