Issue 61650046: code review 61650046: archive/zip: actually test uncompressed size

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61650046: code review 61650046: archive/zip: actually test uncompressed size (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by adg

Modified:
10 years, 2 months ago

Reviewers:
gobot, dsymonds

CC:
dsymonds, golang-codereviews

Visibility:
Public.

Description

archive/zip: actually test uncompressed size Fixes issue 7292.

Patch Set 1 #

Patch Set 2 : diff -r 4dc74e676cd8 https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	src/pkg/archive/zip/reader_test.go	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 2 months ago (2014-02-11 05:01:29 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=1f2f2dc8818b *** archive/zip: actually test uncompressed size Fixes issue 7292. LGTM=dsymonds R=dsymonds ...

10 years, 2 months ago (2014-02-11 05:09:49 UTC) #3

gobot

10 years, 2 months ago (2014-02-11 05:20:21 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-386-minux builder.

Expand All Messages | Collapse All Messages