Issue 6163045: code review 6163045: exp/norm: It is important that the unicode versions of ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6163045: code review 6163045: exp/norm: It is important that the unicode versions of ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by mpvl

Modified:
12 years, 10 months ago

Reviewers:

CC:
r2, r, golang-dev

Visibility:
Public.

Description

exp/norm: It is important that the unicode versions of the various packages align. Replace hard-coded version strings with unicode.Version.

Patch Set 1 #

Patch Set 2 : diff -r bc9a5c0eb13c https://go.googlecode.com/hg #

Patch Set 3 : diff -r bc9a5c0eb13c https://go.googlecode.com/hg #

Patch Set 4 : diff -r 95456588a8e1 https://go.googlecode.com/hg #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/pkg/exp/norm/maketables.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/pkg/exp/norm/normregtest.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

12 years, 10 months ago (2012-05-02 15:19:21 UTC) #1

mpvl

12 years, 10 months ago (2012-05-07 09:41:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a0eefa4e3d01 ***

exp/norm: It is important that the unicode versions of the various packages
align.
Replace hard-coded version strings with unicode.Version.

R=r, r
CC=golang-dev
http://codereview.appspot.com/6163045

Expand All Messages | Collapse All Messages