code review 6160044: exp/locale/collate: from the regression test we derive ...

exp/locale/collate: from the regression test we derive that the spec
dictates a CJK rune is only part of a certain specified range if it
is explicitly defined in the Unicode Codepoint Database.
Fixed the code and some of the tests accordingly.

[mpvl, 2012-05-02 15:40:21]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2012-05-04 20:44:49]

LGTM

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/bu...
File src/pkg/exp/locale/collate/build/colelem.go (right):

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/bu...
src/pkg/exp/locale/collate/build/colelem.go:171: // This will typically not hit.
The DUCET explitly specifies mappings
s/explitly/explicitly/

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/co...
File src/pkg/exp/locale/collate/colelem.go (right):

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/co...
src/pkg/exp/locale/collate/colelem.go:163: // This will typically not hit. The
DUCET explitly specifies mappings
ditto

[mpvl, 2012-05-07 09:51:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=3ab9c81fc9b5 ***

exp/locale/collate: from the regression test we derive that the spec
dictates a CJK rune is only part of a certain specified range if it
is explicitly defined in the Unicode Codepoint Database.
Fixed the code and some of the tests accordingly.

R=r
CC=golang-dev
http://codereview.appspot.com/6160044

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/bu...
File src/pkg/exp/locale/collate/build/colelem.go (right):

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/bu...
src/pkg/exp/locale/collate/build/colelem.go:171: // This will typically not hit.
The DUCET explitly specifies mappings
On 2012/05/04 20:44:49, r wrote:
> s/explitly/explicitly/

Done.

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/co...
File src/pkg/exp/locale/collate/colelem.go (right):

http://codereview.appspot.com/6160044/diff/5001/src/pkg/exp/locale/collate/co...
src/pkg/exp/locale/collate/colelem.go:163: // This will typically not hit. The
DUCET explitly specifies mappings
On 2012/05/04 20:44:49, r wrote:
> ditto

Done.