Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4973)

Issue 61600043: code review 61600043: bench: add "garbage" benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dvyukov
Modified:
10 years, 2 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

bench: add "garbage" benchmark It's based on the famous test/bench/garbage/parser benchmark. But parses only net/http for better stability.

Patch Set 1 #

Patch Set 2 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 4 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 5 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 6 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Total comments: 2

Patch Set 7 : diff -r 66046080a303 https://code.google.com/p/go.benchmarks #

Patch Set 8 : diff -r 66046080a303 https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -0 lines) Patch
M bench/bench.go View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M driver/driver_go10.go View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M driver/driver_go12.go View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
A garbage/garbage.go View 1 2 3 4 5 6 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks
10 years, 2 months ago (2014-02-10 15:51:03 UTC) #1
dvyukov
On 2014/02/10 15:51:03, dvyukov wrote: > Hello mailto:adg@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
10 years, 2 months ago (2014-02-10 16:07:33 UTC) #2
adg
old chunk mismatch please re-upload
10 years, 2 months ago (2014-02-11 05:28:40 UTC) #3
dvyukov
On 2014/02/11 05:28:40, adg wrote: > old chunk mismatch > please re-upload Done
10 years, 2 months ago (2014-02-11 09:09:49 UTC) #4
adg
LGTM https://codereview.appspot.com/61600043/diff/80001/garbage/garbage.go File garbage/garbage.go (right): https://codereview.appspot.com/61600043/diff/80001/garbage/garbage.go#newcode90 garbage/garbage.go:90: runtime.GC() why twice?
10 years, 2 months ago (2014-02-25 05:43:13 UTC) #5
dvyukov
https://codereview.appspot.com/61600043/diff/80001/garbage/garbage.go File garbage/garbage.go (right): https://codereview.appspot.com/61600043/diff/80001/garbage/garbage.go#newcode90 garbage/garbage.go:90: runtime.GC() On 2014/02/25 05:43:13, adg wrote: > why twice? ...
10 years, 2 months ago (2014-02-25 12:26:13 UTC) #6
dvyukov
10 years, 2 months ago (2014-02-25 12:27:01 UTC) #7
*** Submitted as
https://code.google.com/p/go/source/detail?r=b9f69a8adb51&repo=benchmarks ***

bench: add "garbage" benchmark
It's based on the famous test/bench/garbage/parser benchmark.
But parses only net/http for better stability.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/61600043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b