Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 61540047: code review 61540047: ogle/socket: new package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by nigeltao
Modified:
10 years, 1 month ago
Reviewers:
CC:
r
Visibility:
Public.

Description

ogle/socket: new package.

Patch Set 1 #

Patch Set 2 : diff -r 915c0f97f00c https://code.google.com/p/ogle #

Patch Set 3 : diff -r 915c0f97f00c https://code.google.com/p/ogle #

Total comments: 1

Patch Set 4 : diff -r 915c0f97f00c https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -5 lines) Patch
M probe/net.go View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M probe/net_test.go View 1 3 chunks +12 lines, -1 line 0 comments Download
A socket/socket.go View 1 1 chunk +107 lines, -0 lines 0 comments Download
A socket/socket_test.go View 1 2 3 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
10 years, 1 month ago (2014-02-12 06:19:05 UTC) #1
r
LGTM https://codereview.appspot.com/61540047/diff/40001/probe/net.go File probe/net.go (right): https://codereview.appspot.com/61540047/diff/40001/probe/net.go#newcode22 probe/net.go:22: // init starts a network listener and leaves ...
10 years, 1 month ago (2014-02-12 23:15:10 UTC) #2
nigeltao
10 years, 1 month ago (2014-02-13 00:21:58 UTC) #3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b