Issue 61520046: code review 61520046: ogle/probe: update linux/amd64 magic arena_foo_offset c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61520046: code review 61520046: ogle/probe: update linux/amd64 magic arena_foo_offset c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by nigeltao

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/probe: update linux/amd64 magic arena_foo_offset constants. They were determined by inserting into pkg/runtime: runtime·printf("arena_start_offset=%d\n", (uint64)(&runtime·mheap.arena_start) - (uint64)(&runtime·mheap)); $ go version go version devel +72ef9cff4fa9 Mon Feb 10 20:27:31 2014 -0500 linux/amd64

Patch Set 1 #

Patch Set 2 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	probe/probe_linux_amd64.s	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-12 00:29:13 UTC) #1

nigeltao

10 years, 2 months ago (2014-02-12 00:38:37 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=b3f4d2b8af30 ***

ogle/probe: update linux/amd64 magic arena_foo_offset constants.

They were determined by inserting into pkg/runtime:
runtime·printf("arena_start_offset=%d\n",
(uint64)(&runtime·mheap.arena_start) - (uint64)(&runtime·mheap));

$ go version
go version devel +72ef9cff4fa9 Mon Feb 10 20:27:31 2014 -0500 linux/amd64

LGTM=r
R=r
https://codereview.appspot.com/61520046

Expand All Messages | Collapse All Messages