code review 6121044: test: add test for order of evaluation of map index on ...

test: add test for order of evaluation of map index on left of =

Gccgo used to get this wrong.

[iant, 2012-04-24 16:28:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-04-24 16:42:54]

LGTM
On Apr 24, 2012 9:28 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> test: add test for order of evaluation of map index on left of =
>
> Gccgo used to get this wrong.
>
> Please review this at
http://codereview.appspot.com/**6121044/<http://codereview.appspot.com/6121044/>
>
> Affected files:
>  M test/reorder.go
>
>
> Index: test/reorder.go
> ==============================**==============================**=======
> --- a/test/reorder.go
> +++ b/test/reorder.go
> @@ -19,6 +19,7 @@
>        p6()
>        p7()
>        p8()
> +       p9()
>  }
>
>  var gx []int
> @@ -119,3 +120,11 @@
>        i := 0
>        i, x[i], x[5] = 1, 100, 500
>  }
> +
> +func p9() {
> +       m := make(map[int]int)
> +       m[0] = len(m)
> +       if m[0] != 0 {
> +               panic(m[0])
> +       }
> +}
>
>
>

[iant, 2012-04-24 17:17:50]

*** Submitted as http://code.google.com/p/go/source/detail?r=6a62349f0bf8 ***

test: add test for order of evaluation of map index on left of =

Gccgo used to get this wrong.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6121044