code review 6119051: mime: make ParseMediaType return zero results on error

mime: make ParseMediaType return zero results on error

Fixes issue 3562

[bradfitz, 2012-04-25 17:38:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-04-25 18:34:46]

Why?

[rsc, 2012-04-25 18:39:03]

(The partial result doesn't make sense and contradicts the documentation.)

But where is err getting set?  I would rather just return there
instead of later.

[bradfitz, 2012-04-25 18:56:32]

Hello golang-dev@googlegroups.com, adg@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-04-25 18:56:39]

On Wed, Apr 25, 2012 at 11:38 AM, Russ Cox <rsc@golang.org> wrote:

> (The partial result doesn't make sense and contradicts the documentation.)
>
> But where is err getting set?  I would rather just return there
> instead of later.


It's not.  That block doesn't matter; removed.

[bradfitz, 2012-04-25 19:01:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=1384d7510575 ***

mime: make ParseMediaType return zero results on error

Fixes issue 3562

R=golang-dev, adg, rsc
CC=golang-dev
http://codereview.appspot.com/6119051

[rsc, 2012-04-25 19:02:31]

LGTM

[reply all]