code review 61020043: crypto/x509: add example of using a custom root list.

crypto/x509: add example of using a custom root list.

Fixes issue 6267.

[agl1, 2014-02-07 19:01:07]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[josharian, 2014-02-08 01:36:53]

On 2014/02/07 19:01:07, agl1 wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

I think that it might be more helpful to have the example focus on how to
construct (and use?) a *tls.Config with a custom RootCAs. IIUC, that's the topic
that first sparked issue 6267, and I think it is the most common use of a custom
set of root certs.

The sequence might look something like: x509.NewCertPool(), AppendCertsFromPEM,
tls.Config{RootCAs: pool}, BuildNameToCertificate,
http.Transport{TLSClientConfig: conf},
http.Client{Transport: transport}, use http.Client.

That said, the cert verification done in this example is interesting and worth
keeping.

[r, 2014-02-13 19:37:06]

https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
File src/pkg/crypto/x509/example_test.go (right):

https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
src/pkg/crypto/x509/example_test.go:20: -----BEGIN CERTIFICATE-----
how about making these monsters constants at the top of the function, so the
code flows more compactly.

[agl1, 2014-02-18 18:51:45]

have also added an example for tls.Dial.

https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
File src/pkg/crypto/x509/example_test.go (right):

https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
src/pkg/crypto/x509/example_test.go:20: -----BEGIN CERTIFICATE-----
On 2014/02/13 19:37:07, r wrote:
> how about making these monsters constants at the top of the function, so the
> code flows more compactly.

Done.

[josharian, 2014-02-18 20:51:33]

On 2014/02/18 18:51:45, agl1 wrote:
> have also added an example for tls.Dial.
> 
>
https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
> File src/pkg/crypto/x509/example_test.go (right):
> 
>
https://codereview.appspot.com/61020043/diff/40001/src/pkg/crypto/x509/exampl...
> src/pkg/crypto/x509/example_test.go:20: -----BEGIN CERTIFICATE-----
> On 2014/02/13 19:37:07, r wrote:
> > how about making these monsters constants at the top of the function, so the
> > code flows more compactly.
> 
> Done.

Looks like you might not have uploaded the latest.

[agl1, 2014-02-18 20:53:10]

Nuts, sorry. Done.

[r, 2014-02-18 21:04:48]

LGTM

[josharian, 2014-02-18 22:08:47]

LGTM

[agl1, 2014-02-19 16:18:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=f764dd2d3ad6 ***

crypto/x509: add example of using a custom root list.

Fixes issue 6267.

LGTM=r, josharian
R=golang-codereviews, josharian, r
CC=golang-codereviews
https://codereview.appspot.com/61020043

[gobot, 2014-02-19 17:54:30]

This CL appears to have broken the windows-amd64-race builder.