Issue 609042: code review 609042: build script tweaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 609042: code review 609042: build script tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
14 years, 12 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

build script tweaks factor out environment variable checks. infer $GOROOT etc during build if not set. it's still necessary to set them for yourself to use the standard Makefiles. when running all.bash, don't recompile all the go packages in run.bash, since make.bash already did.

Patch Set 1 #

Patch Set 2 : code review 609042: build script tweaks #

Patch Set 3 : code review 609042: build script tweaks #

Patch Set 4 : code review 609042: build script tweaks #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -49 lines)			Patch
M	src/all.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/env.bash	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
M	src/make.bash	View		1 chunk	+1 line, -38 lines	0 comments	Download
M	src/run.bash	View	1 2	3 chunks	+27 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 12 months ago (2010-03-31 18:16:57 UTC) #1

rsc

14 years, 12 months ago (2010-04-01 02:48:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=04f6dd559f07 ***

build script tweaks

factor out environment variable checks.
infer $GOROOT etc during build if not set.
it's still necessary to set them for yourself
to use the standard Makefiles.

when running all.bash, don't recompile all the
go packages in run.bash, since make.bash already did.

R=r
CC=golang-dev
http://codereview.appspot.com/609042

Expand All Messages | Collapse All Messages