Issue 60500046: code review 60500046: crypto/rsa: explain random parameter for GenerateKey an...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60500046: code review 60500046: crypto/rsa: explain random parameter for GenerateKey an... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by minux1

Modified:
10 years, 3 months ago

Reviewers:
agl1, gobot

CC:
golang-codereviews, agl1

Visibility:
Public.

Description

crypto/rsa: explain random parameter for GenerateKey and GenerateMultiPrimeKey. Fixes issue 6850.

Patch Set 1 #

Patch Set 2 : diff -r ae14bde9ce3c https://code.google.com/p/go #

Patch Set 3 : diff -r ae14bde9ce3c https://code.google.com/p/go #

Patch Set 4 : diff -r 5c3270d0abf1 https://code.google.com/p/go #

Patch Set 5 : diff -r 5c3270d0abf1 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
		src/pkg/crypto/rsa/rsa.go	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-02-06 07:00:57 UTC) #1

minux1

*** Submitted as https://code.google.com/p/go/source/detail?r=ee32f4cd6b44 *** crypto/rsa: explain random parameter for GenerateKey and GenerateMultiPrimeKey. Fixes issue ...

10 years, 3 months ago (2014-02-13 20:56:56 UTC) #3

minux1

10 years, 3 months ago (2014-02-13 21:35:27 UTC) #5

On Feb 13, 2014 4:16 PM, <gobot@golang.org> wrote:
> This CL appears to have broken the linux-amd64 builder.
it's a known GC issue.

Expand All Messages | Collapse All Messages