Issue 6040046: code review 6040046: cmd/go: do not ignore DepsErrors in 'go run'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6040046: code review 6040046: cmd/go: do not ignore DepsErrors in 'go run' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rh

Modified:
12 years ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

cmd/go: do not ignore DepsErrors in 'go run' Fixes issue 3490.

Patch Set 1 #

Patch Set 2 : diff -r 99292bad0d6d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 99292bad0d6d https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/go/run.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2012-04-16 03:51:30 UTC) #1

dave_cheney.net

LGTM. An observation, pack exits with 0 when asked to pack an empty directory, I'm ...

12 years, 1 month ago (2012-04-18 10:51:38 UTC) #2

rsc

12 years ago (2012-04-30 21:00:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=1d4d8324085b ***

cmd/go: do not ignore DepsErrors in 'go run'

Fixes issue 3490.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6040046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages