Issue 60290043: code review 60290043: ogle: udpate A+C

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60290043: code review 60290043: ogle: udpate A+C (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by r

Modified:
10 years, 2 months ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle: udpate A+C

Patch Set 1 #

Patch Set 2 : diff -r 40fdb470a9cc https://code.google.com/p/ogle #

Patch Set 3 : diff -r 40fdb470a9cc https://code.google.com/p/ogle #

Patch Set 4 : diff -r 40fdb470a9cc https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, --1 lines)			Patch
M	AUTHORS	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	CONTRIBUTORS	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	lib/codereview/codereview.cfg	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-05 01:03:52 UTC) #1

10 years, 2 months ago (2014-02-05 01:10:18 UTC) #4

*** Submitted as https://code.google.com/p/ogle/source/detail?r=ea807a82f29d ***

ogle: udpate A+C

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/60290043

Expand All Messages | Collapse All Messages