code review 6011057: fmt: fix crash of %b on huge negative int64

fmt: fix crash of %b on huge negative int64
The buffer had 64 bytes but needs one more for the sign.

Fixes issue 3510.

[r, 2012-04-12 22:52:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2012-04-12 22:59:09]

LGTM. 

> +    // Used to crash because nByte didn't allow for a sign.
> +    {"%b", int64(-1 << 63),
"-1000000000000000000000000000000000000000000000000000000000000000"},

Maybe reference issue 3510 here?

[dsymonds, 2012-04-12 22:59:34]

LGTM

[r, 2012-04-12 23:28:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=344d5c33331a ***

fmt: fix crash of %b on huge negative int64
The buffer had 64 bytes but needs one more for the sign.

Fixes issue 3510.

R=golang-dev, dave, dsymonds
CC=golang-dev
http://codereview.appspot.com/6011057

[r2, 2012-04-12 23:30:05]

On 13/04/2012, at 8:59 AM, Dave Cheney wrote:

> LGTM. 
> 
>> +    // Used to crash because nByte didn't allow for a sign.
>> +    {"%b", int64(-1 << 63),
"-1000000000000000000000000000000000000000000000000000000000000000"},
> 
> Maybe reference issue 3510 here?

I prefer not to add out-of-band details like that to code unless it adds
context. Here the bug is so simple and well-defined and easy to reproduce that
such a link would encourage people to look elsewhere yet learn nothing for their
trouble.

-rob

[dave_cheney.net, 2012-04-12 23:35:52]

Sure thing, there is always the linkage via the commit message to the CL and
issue. 

On 13/04/2012, at 9:29, Rob 'Commander' Pike <r@google.com> wrote:

> 
> On 13/04/2012, at 8:59 AM, Dave Cheney wrote:
> 
>> LGTM. 
>> 
>>> +    // Used to crash because nByte didn't allow for a sign.
>>> +    {"%b", int64(-1 << 63),
"-1000000000000000000000000000000000000000000000000000000000000000"},
>> 
>> Maybe reference issue 3510 here?
> 
> I prefer not to add out-of-band details like that to code unless it adds
context. Here the bug is so simple and well-defined and easy to reproduce that
such a link would encourage people to look elsewhere yet learn nothing for their
trouble.
> 
> -rob
> 
>