Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3206)

Issue 60070044: code review 60070044: bench: move benchmarks from other repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by dvyukov
Modified:
10 years, 1 month ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

bench: move benchmarks from other repo No code changes. Dir structure is changed. I think it's mostly TBR, but if you want to take the final look.

Patch Set 1 #

Patch Set 2 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Patch Set 4 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2853 lines, -0 lines) Patch
A bench/bench.go View 1 1 chunk +16 lines, -0 lines 0 comments Download
A build/build.go View 1 1 chunk +84 lines, -0 lines 0 comments Download
A driver/driver.go View 1 1 chunk +401 lines, -0 lines 0 comments Download
A driver/driver_darwin.go View 1 1 chunk +48 lines, -0 lines 0 comments Download
A driver/driver_freebsd.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A driver/driver_go10.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
A driver/driver_go12.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
A driver/driver_linux.go View 1 1 chunk +158 lines, -0 lines 0 comments Download
A driver/driver_unix.go View 1 1 chunk +62 lines, -0 lines 0 comments Download
A driver/driver_windows.go View 1 1 chunk +140 lines, -0 lines 0 comments Download
A json/json.go View 1 1 chunk +79 lines, -0 lines 0 comments Download
A json/json_data.go View 1 1 chunk +1810 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks
10 years, 1 month ago (2014-02-05 18:21:26 UTC) #1
adg
LGTM
10 years, 1 month ago (2014-02-10 04:56:16 UTC) #2
dvyukov
10 years, 1 month ago (2014-02-10 15:22:54 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=f2c11d87b6d3&repo=benchmarks ***

bench: move benchmarks from other repo
No code changes.
Dir structure is changed.
I think it's mostly TBR, but if you want to take the final look.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/60070044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b