Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(436)

Issue 5991066: code review 5991066: cmd/cgo: support Linux/ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by minux1
Modified:
12 years, 10 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, rsc
Visibility:
Public.

Description

cmd/cgo: support Linux/ARM Part 3 of CL 5601044 (cgo: Linux/ARM support)

Patch Set 1 #

Patch Set 2 : diff -r 734071724054 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 734071724054 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 512073e3b7f2 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1a7674b1f1ed https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/cmd/cgo/gcc.go View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2012-04-07 19:28:46 UTC) #1
dave_cheney.net
LGTM - tested on Pandaboard ARMv7
12 years, 11 months ago (2012-04-09 08:10:06 UTC) #2
dave_cheney.net
On 2012/04/09 08:10:06, dfc wrote: > LGTM - tested on Pandaboard ARMv7 Looks good on ...
12 years, 11 months ago (2012-04-09 10:31:55 UTC) #3
dave_cheney.net
On 2012/04/09 08:10:06, dfc wrote: > LGTM - tested on Pandaboard ARMv7 Looks good on ...
12 years, 11 months ago (2012-04-09 10:31:56 UTC) #4
rsc
Why is this necessary? The 32/64 is necessary to pick the right architecture when invoking ...
12 years, 11 months ago (2012-04-09 16:09:37 UTC) #5
minux1
On Tue, Apr 10, 2012 at 12:09 AM, Russ Cox <rsc@golang.org> wrote: > Why is ...
12 years, 11 months ago (2012-04-09 16:13:36 UTC) #6
minux1
12 years, 10 months ago (2012-05-04 10:26:43 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=40202593eb00 ***

cmd/cgo: support Linux/ARM
        Part 3 of CL 5601044 (cgo: Linux/ARM support)

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/5991066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b