Issue 5988057: code review 5988057: go/build: cgo is supported on Linux/ARM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5988057: code review 5988057: go/build: cgo is supported on Linux/ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

go/build: cgo is supported on Linux/ARM Last Part of CL 5601044 (cgo: Linux/ARM support) Fixes issue 1880.

Patch Set 1 #

Patch Set 2 : diff -r 734071724054 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 734071724054 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ed6ca5054698 https://code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/go/build/build.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2012-04-07 19:30:17 UTC) #1

dave_cheney.net

On 2012/04/09 08:10:24, dfc wrote: > LGTM - tested on Pandaboard ARMv7 Looks good on ...

12 years, 11 months ago (2012-04-09 10:31:27 UTC) #3

minux1

12 years, 10 months ago (2012-05-04 10:34:28 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d65c6e0efbb3 ***

go/build: cgo is supported on Linux/ARM
        Last Part of CL 5601044 (cgo: Linux/ARM support)
        Fixes issue 1880.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/5988057

Expand All Messages | Collapse All Messages