Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1271)

Issue 5987070: code review 5987070: os: fix IsPermission on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by brainman
Modified:
11 years, 11 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

os: fix IsPermission on windows Fixes issue 3482.

Patch Set 1 #

Patch Set 2 : diff -r 9a55b03991e3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9a55b03991e3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a7db811befb8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/error_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 11 months ago (2012-04-09 23:31:52 UTC) #1
brainman
This fix checks for error I see myself. Perhaps, there are others. Alex
11 years, 11 months ago (2012-04-09 23:32:15 UTC) #2
rsc
LGTM
11 years, 11 months ago (2012-04-09 23:48:48 UTC) #3
brainman
11 years, 11 months ago (2012-04-10 00:07:37 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=1b2b113a2d66 ***

os: fix IsPermission on windows

Fixes issue 3482.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5987070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b